Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspect ratios shouldn't contain zero #3664

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Aspect ratios shouldn't contain zero #3664

merged 1 commit into from
Nov 7, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

Fixes: #3663

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner November 6, 2024 18:07
robert-ancell
robert-ancell approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we don't have to support a new compositor with zero width windows :)

@RAOF RAOF added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit fa1ea7f Nov 7, 2024
38 of 39 checks passed
@RAOF RAOF deleted the saner-aspect-ratio-default branch November 7, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-ancell robert-ancell robert-ancell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Divide by zero in WindowInfo::constrain_resize()
3 participants
@AlanGriffiths @robert-ancell @RAOF