Fix X11 dropdowns persisting for too long on unfocus

[tarek-y-ismail]

For some reason, our code ignored synthetic unmap requests, even though ICCCM 4.1.4 doesn't mention that it should be ignored. I tried commenting out the couple of lines responsible for ignoring the request and tested with gimp, qtcreator, and imagemagick. All seem to work better, especially gimp and qtcreator where this bug is most apparent.

[AlanGriffiths]

This looks sensible and, at worst, harmless.

But how to reproduce the problem it purports to solve? (qtcreator uses Wayland, when I switch focus from gimp menus are unmapped, ...)

[tarek-y-ismail]

But how to reproduce the problem it purports to solve? (qtcreator uses Wayland, when I switch focus from gimp menus are unmapped, ...)

For GIMP, the issue is that whenever you have a menu open, if you open another menu or click somewhere in the application to close the menu, the menu stays displayed for a second or two longer than needed. It's most apparent if you open the file menu and drag the cursor across the menubar.

For QTCreator, you can run it as QT_QPA_PLATFORM=xcb qtcreator, then it will use the X11 backend. Reproduction is similar to GIMP.

Imagemagick is still broken in other ways, but menus seem to also close at the proper time as well (although it's a bit hard to see through the mess)