Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs checks #3627

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Fix docs checks #3627

merged 6 commits into from
Oct 15, 2024

Conversation

tarek-y-ismail
Copy link
Contributor

Adds new words to the custom wordlist to fix the spelling check, and fixes (most) URLs .

@tarek-y-ismail tarek-y-ismail requested a review from Saviq October 10, 2024 14:40
AlanGriffiths
AlanGriffiths previously requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits

doc/sphinx/how-to/getting_involved_in_mir.md Outdated Show resolved Hide resolved
doc/sphinx/reference/dso_versioning_guide.md Show resolved Hide resolved
@tarek-y-ismail tarek-y-ismail marked this pull request as ready for review October 11, 2024 13:13
@tarek-y-ismail tarek-y-ismail requested a review from a team as a code owner October 11, 2024 13:13
Saviq
Saviq approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit.

doc/sphinx/reference/continuous-integration.md Outdated Show resolved Hide resolved
@tarek-y-ismail tarek-y-ismail requested a review from Saviq October 14, 2024 06:26
Saviq
Saviq approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green!

Thanks :)

@Saviq Saviq enabled auto-merge October 14, 2024 07:27
@Saviq Saviq added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 2ba30d8 Oct 15, 2024
38 checks passed
@Saviq Saviq deleted the fix-docs-checks branch October 15, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saviq Saviq Saviq approved these changes

@AlanGriffiths AlanGriffiths Awaiting requested review from AlanGriffiths

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarek-y-ismail @Saviq @AlanGriffiths