Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharedLibrary::Handle no longer defines the hash function in std #3625

Merged
merged 1 commit into from
Oct 7, 2024
Merged

SharedLibrary::Handle no longer defines the hash function in std #3625

merged 1 commit into from
Oct 7, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Oct 7, 2024

No description provided.

@mattkae mattkae requested a review from a team as a code owner October 7, 2024 15:15
@mattkae mattkae force-pushed the bugfix/std_in_sym_generator branch from 71e6313 to 0f94702 Compare October 7, 2024 15:19
AlanGriffiths
AlanGriffiths approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@AlanGriffiths
Copy link
Collaborator

AlanGriffiths commented Oct 7, 2024 •
edited
Loading

Sure

but you also need to fix symbols.map! ;)

@mattkae mattkae force-pushed the bugfix/std_in_sym_generator branch from 0f94702 to 0f34e92 Compare October 7, 2024 15:27
@mattkae
Copy link
Contributor Author

mattkae commented Oct 7, 2024

Sure

but you also need to fix symbols.map! ;)

Oh and it was ending up in 2.18! Funny. That's a bug for sure

@mattkae mattkae force-pushed the bugfix/std_in_sym_generator branch from 0f34e92 to d57046f Compare October 7, 2024 15:30
tarek-y-ismail
tarek-y-ismail reviewed Oct 7, 2024
View reviewed changes
src/common/symbols.map Outdated
@@ -1,4 +1,5 @@
MIR_COMMON_2.17 {

bcmnopqrstuvwxyz1234567890 MIR_COMMON_2.17 {
Copy link
Contributor

@tarek-y-ismail tarek-y-ismail Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? Is this the doing of one of your cats? 🐈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad haha

@mattkae mattkae force-pushed the bugfix/std_in_sym_generator branch from d57046f to b277640 Compare October 7, 2024 15:34
@mattkae mattkae merged commit 101d1e0 into MIRENG-653/platform-specific-options Oct 7, 2024
24 of 25 checks passed
@mattkae mattkae deleted the bugfix/std_in_sym_generator branch October 7, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarek-y-ismail tarek-y-ismail tarek-y-ismail left review comments

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattkae @AlanGriffiths @tarek-y-ismail