New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not extend the `InputDeviceHub` lifetime beyond teardown #3611

Merged

AlanGriffiths merged 1 commit into main from fix-3610

Sep 25, 2024

Collaborator

AlanGriffiths commented Sep 25, 2024

Fixes: #3610


          Do not extend the InputDeviceHub lifetime beyond teardown

9fb02e4

AlanGriffiths requested a review from a team as a code owner

September 25, 2024 10:37

Collaborator Author

AlanGriffiths commented Sep 25, 2024

@Saviq another cherry-pick for 2.18

It only affects shells that use miral::InputConfiguration (which will probably remain rare, but they will crash on exit)

Contributor

tarek-y-ismail commented Sep 25, 2024

Can confirm that this fixes the smoke tests

tarek-y-ismail approved these changes

View reviewed changes

tarek-y-ismail added this pull request to the merge queue

Collaborator Author

AlanGriffiths commented Sep 25, 2024 •

edited

Loading

Can confirm that this fixes the smoke tests

You should also confirm it doesn't break the demo of input configuration changes. (I.e. changes written to ~/.config/mir_demo_server.input are applied up by mir_demo_server)

Works on my machine, but...

tarek-y-ismail removed this pull request from the merge queue due to a manual request

tarek-y-ismail added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

tarek-y-ismail added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

Saviq added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

AlanGriffiths added this pull request to the merge queue

github-merge-queue bot pushed a commit that referenced this pull request


          Do not extend the InputDeviceHub lifetime beyond teardown (#3611)

ac20d99

Fixes: #3610

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

Saviq added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

AlanGriffiths added this pull request to the merge queue

Merged via the queue into main with commit c89d7fd

24 of 25 checks passed

AlanGriffiths deleted the fix-3610 branch

September 25, 2024 14:04

Saviq pushed a commit that referenced this pull request


          Do not extend the InputDeviceHub lifetime beyond teardown (#3611)

0a3a87b

Fixes: #3610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet