Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platforms/atomic-kms: Populate supported pixel formats correctly #3596

Merged

Conversation

RAOF
Copy link
Contributor

@RAOF RAOF commented Sep 12, 2024

DisplayConfigurationOutput.pixel_formats now contains the list of accepted pixel formats (or, at least, those pixel formats that are representable in the MirPixelFormats enum; many aren't).

`DisplayConfigurationOutput.pixel_formats` now contains the list of accepted
pixel formats (or, at least, those pixel formats that are representable in
the `MirPixelFormats` enum; many aren't).
@RAOF RAOF requested a review from a team as a code owner September 12, 2024 07:49
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits picked

src/platforms/atomic-kms/server/kms/atomic_kms_output.cpp Outdated Show resolved Hide resolved
src/platforms/atomic-kms/server/kms/atomic_kms_output.cpp Outdated Show resolved Hide resolved
@AlanGriffiths AlanGriffiths merged commit 608dfb2 into initial-atomic-kms-platform Oct 1, 2024
37 checks passed
@AlanGriffiths AlanGriffiths deleted the MIRENG-654/pull-out-output-format branch October 1, 2024 09:34
tarek-y-ismail added a commit that referenced this pull request Oct 15, 2024
`DisplayConfigurationOutput.pixel_formats` now contains the list of
accepted pixel formats (or, at least, those pixel formats that are
representable in the `MirPixelFormats` enum; many aren't).

---------

Co-authored-by: tarek-y-ismail <[email protected]>
Co-authored-by: Alan Griffiths <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants