-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing wl_surface.enter
events for outputs enabled at runtime.
#3585
Conversation
[This may be spurious - I just noticed the amd64 snap build failed and I was testing edge] Trying this (miriway --channel=edge/mir-pr3585) I find that disconnecting an external monitor gives:
When the display adapts (not sure "nil" is the best we can do but...) When reconnecting again: expect: an Curiously, when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
So disconnecting and reconnecting the monitor physically doesn't call |
Weird huh? (But I was testing main, not this PR) |
Well, when I use i3 and physically disconnect the HDMI on my external monitor, it doesn't call xrandr to update the output state, maybe this is a similar situation? |
Hmm, $ WAYLAND_DEBUG=1 gnome-calculator 2>&1 | grep -E "wl_surface.*?(enter|leave)"
[ 244392.196] [email protected](wl_output@16) Unplug HDMI: [ 249616.380] [email protected](wl_output@16) Plug it back: [ 253946.082] [email protected](wl_output@29) |
See "This may be spurious - I just noticed the amd64 snap build failed and I was testing edge" |
In my previous fix for #3414, I accidentally disabled sending
wl_surface.enter
events for surfaces on outputs enabled at runtime. This PR resolves that issue while still addressing #3414.