Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live scale changes #3583

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Live scale changes #3583

merged 3 commits into from
Sep 6, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

@AlanGriffiths AlanGriffiths commented Sep 3, 2024 •
edited
Loading

Surfaces need to track scale changes on outputs they appear on

Fixes: #3552

(Reviewers note: this depends on #3586)

@AlanGriffiths
Copy link
Collaborator Author

@tarek-y-ismail your time is better spend reviewing things that are "ready for review". (This is "draft" for a reason: it breaks stuff - currently "leave" notifications.)

@tarek-y-ismail
Copy link
Contributor

@tarek-y-ismail your time is better spend reviewing things that are "ready for review". (This is "draft" for a reason: it breaks stuff - currently "leave" notifications.)

No worries, I was just curious and thankfully the PR was small so it didn't take much time to read through. It definitely revealed stuff that I didn't think about before when first implementing fractional scaling :)

Base automatically changed from scale to main September 5, 2024 08:51
@AlanGriffiths AlanGriffiths changed the base branch from main to Fix-OutputManager-registration September 5, 2024 14:03
@AlanGriffiths AlanGriffiths marked this pull request as ready for review September 5, 2024 14:04
@AlanGriffiths AlanGriffiths requested a review from a team as a code owner September 5, 2024 14:04
Base automatically changed from Fix-OutputManager-registration to main September 5, 2024 21:07
hbatagelo
hbatagelo requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@hbatagelo hbatagelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected. I've made a few suggestions, mostly to ensure consistency with the use of east const. I would also recommend adding const where applicable (e.g. fractional_scale).

src/server/frontend_wayland/wayland_surface_observer.h Outdated Show resolved Hide resolved
src/server/scene/basic_surface.cpp Outdated Show resolved Hide resolved
src/server/scene/basic_surface.cpp Outdated Show resolved Hide resolved
tests/mir_test_framework/window_management_test_harness.cpp Outdated Show resolved Hide resolved
hbatagelo
hbatagelo approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@hbatagelo hbatagelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbatagelo hbatagelo enabled auto-merge September 6, 2024 14:24
@hbatagelo hbatagelo added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit ecc4899 Sep 6, 2024
25 of 26 checks passed
@hbatagelo hbatagelo deleted the live-scale-changes branch September 6, 2024 21:05
AlanGriffiths pushed a commit that referenced this pull request Sep 9, 2024
@hbatagelo @AlanGriffiths
Live scale changes (#3583)
4e10bef 
Surfaces need to track scale changes on outputs they appear on

Fixes: #3552

(Reviewers note: this depends on #3586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarek-y-ismail tarek-y-ismail tarek-y-ismail approved these changes

@hbatagelo hbatagelo hbatagelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGriffiths @tarek-y-ismail @hbatagelo