-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies to mir-x11-kiosk #3486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3486 +/- ##
=======================================
Coverage 76.96% 76.96%
=======================================
Files 1081 1081
Lines 69384 69384
=======================================
+ Hits 53398 53400 +2
+ Misses 15986 15984 -2 ☔ View full report in Codecov by Sentry. |
mattkae
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool by me 👍
Saviq
pushed a commit
that referenced
this pull request
Aug 8, 2024
These are needed to make it work in a snap environment, so make life easy by adding them here
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
> Backport of #3460, #3480, #3486 to 2.16 for release into `core22` Add a mir-kiosk-x11 package (to replace https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps) The intended use is to include this from our release PPA to support snaps that wrap X11 apps. AFAICS there's no reason to also consider adding this to the Ubuntu archive.
Saviq
pushed a commit
that referenced
this pull request
Aug 8, 2024
These are needed to make it work in a snap environment, so make life easy by adding them here
Merged
Saviq
pushed a commit
that referenced
this pull request
Aug 8, 2024
These are needed to make it work in a snap environment, so make life easy by adding them here
Saviq
pushed a commit
that referenced
this pull request
Aug 8, 2024
These are needed to make it work in a snap environment, so make life easy by adding them here
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
> Backport of #3460, #3480, #3486 to 2.17 for release into `core22` Add a mir-kiosk-x11 package (to replace https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps) The intended use is to include this from our release PPA to support snaps that wrap X11 apps. AFAICS there's no reason to also consider adding this to the Ubuntu archive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are needed to make it work in a snap environment, so make life easy by adding them here