Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies to mir-x11-kiosk #3486

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Add dependencies to mir-x11-kiosk #3486

merged 1 commit into from
Jul 15, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

These are needed to make it work in a snap environment, so make life easy by adding them here

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner July 15, 2024 16:53
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.96%. Comparing base (59bd787) to head (e75588e).
Report is 355 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3486   +/-   ##
=======================================
  Coverage   76.96%   76.96%           
=======================================
  Files        1081     1081           
  Lines       69384    69384           
=======================================
+ Hits        53398    53400    +2     
+ Misses      15986    15984    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool by me 👍

@mattkae mattkae added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 04c0902 Jul 15, 2024
22 of 24 checks passed
@mattkae mattkae deleted the update-x11-kiosk branch July 15, 2024 19:39
Saviq pushed a commit that referenced this pull request Aug 8, 2024
These are needed to make it work in a snap environment, so make life
easy by adding them here
@Saviq Saviq mentioned this pull request Aug 8, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2024
> Backport of #3460, #3480, #3486 to 2.16 for release into `core22`

Add a mir-kiosk-x11 package (to replace
https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps)

The intended use is to include this from our release PPA to support
snaps that wrap X11 apps. AFAICS there's no reason to also consider
adding this to the Ubuntu archive.
Saviq pushed a commit that referenced this pull request Aug 8, 2024
These are needed to make it work in a snap environment, so make life
easy by adding them here
@Saviq Saviq mentioned this pull request Aug 8, 2024
Saviq pushed a commit that referenced this pull request Aug 8, 2024
These are needed to make it work in a snap environment, so make life
easy by adding them here
Saviq pushed a commit that referenced this pull request Aug 8, 2024
These are needed to make it work in a snap environment, so make life
easy by adding them here
github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2024
> Backport of #3460, #3480, #3486 to 2.17 for release into `core22`

Add a mir-kiosk-x11 package (to replace
https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps)

The intended use is to include this from our release PPA to support
snaps that wrap X11 apps. AFAICS there's no reason to also consider
adding this to the Ubuntu archive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants