Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding a threat model diagram for Ubuntu Frame #3484

Merged

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Jul 15, 2024

Copy link

github-actions bot commented Jul 15, 2024

Everyone contributing to this PR have now signed the CLA. Thanks!

@mattkae mattkae force-pushed the MIRENG-581-convert-the-threat-model-diagram-into-mermaid-on-rtd branch 4 times, most recently from 996f7ee to 0d29e46 Compare July 15, 2024 15:29
@mattkae mattkae requested a review from Saviq July 15, 2024 15:36
@mattkae mattkae marked this pull request as ready for review July 15, 2024 15:36
@mattkae mattkae requested a review from a team as a code owner July 15, 2024 15:36
@mattkae mattkae changed the title docs: defining a threat model for Ubuntu Frame docs: adding a threat model diagram for Ubuntu Frame Jul 15, 2024
@Saviq
Copy link
Collaborator

Saviq commented Jul 29, 2024

Dropping a screenshot so we can talk about it:
obraz

The links between OSK and Mir should be both content and input, or go both ways?

We're also missing app that communicates with Mir for input, window management and window contents.

@mattkae mattkae force-pushed the MIRENG-581-convert-the-threat-model-diagram-into-mermaid-on-rtd branch from 0d29e46 to 83feb90 Compare July 29, 2024 14:00
@mattkae
Copy link
Contributor Author

mattkae commented Jul 29, 2024

@Saviq Like this?
image

@Saviq
Copy link
Collaborator

Saviq commented Jul 29, 2024

@Saviq Like this?

I think two were better for OSK, unidirectional content and bidirectional input.

Also app needs input / window management one way, and content the other.

@mattkae mattkae force-pushed the MIRENG-581-convert-the-threat-model-diagram-into-mermaid-on-rtd branch from 83feb90 to 0ffb9b5 Compare July 29, 2024 14:20
@mattkae
Copy link
Contributor Author

mattkae commented Jul 29, 2024

image

@mattkae mattkae force-pushed the MIRENG-581-convert-the-threat-model-diagram-into-mermaid-on-rtd branch from 0ffb9b5 to 14be68b Compare July 29, 2024 14:22
@Saviq
Copy link
Collaborator

Saviq commented Jul 29, 2024

OK, so bidirectional doesn't look too good. Let's just mark the unidirectional edges with input to OSK, input/contents back to Mir.

We should jump on a call to whack those out, this is too much overhead :)

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits!

Comment on lines 17 to 18
osk--content-->shell
shell<--input-->osk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
osk--content-->shell
shell<--input-->osk
osk--content/input-->shell
shell--input-->osk

snapd--configuration-->shell
display--visuals-->user
operator_app--help message-->shell
user--io events-->shell
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
user--io events-->shell
user--input events-->shell

@mattkae mattkae force-pushed the MIRENG-581-convert-the-threat-model-diagram-into-mermaid-on-rtd branch from 14be68b to c27ba1a Compare July 29, 2024 15:35
@mattkae mattkae enabled auto-merge July 29, 2024 15:35
@mattkae mattkae added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit 8929aae Jul 29, 2024
33 of 35 checks passed
@mattkae mattkae deleted the MIRENG-581-convert-the-threat-model-diagram-into-mermaid-on-rtd branch July 29, 2024 18:08
@AlanGriffiths AlanGriffiths mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants