Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler "plumbing" #3471

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Simpler "plumbing" #3471

merged 3 commits into from
Jul 11, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

No description provided.

@AlanGriffiths AlanGriffiths mentioned this pull request Jul 10, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.14%. Comparing base (de5f7f5) to head (922d817).

Files with missing lines Patch % Lines
src/platforms/evdev/libinput_device.cpp 25.00% 9 Missing ⚠️
src/server/input/default_input_device_hub.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           feature/620    #3471      +/-   ##
===============================================
- Coverage        77.14%   77.14%   -0.01%     
===============================================
  Files             1076     1076              
  Lines            69118    69099      -19     
===============================================
- Hits             53323    53305      -18     
+ Misses           15795    15794       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlanGriffiths AlanGriffiths marked this pull request as ready for review July 11, 2024 10:33
@AlanGriffiths AlanGriffiths requested a review from a team as a code owner July 11, 2024 10:33
@AlanGriffiths AlanGriffiths requested a review from mattkae July 11, 2024 10:33
mattkae
mattkae requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense with a lot less plumbing required! I think we just need to unregister_interest, which I will do. Testing this now

src/server/input/default_input_device_hub.cpp Show resolved Hide resolved
mattkae
mattkae approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mattkae mattkae merged commit 1ddf5d5 into feature/620 Jul 11, 2024
23 of 24 checks passed
@mattkae mattkae deleted the replumb-LED-control branch July 11, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkae mattkae mattkae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlanGriffiths @mattkae