Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11-kiosk #3460

Merged
merged 3 commits into from
Jul 12, 2024
Merged

x11-kiosk #3460

merged 3 commits into from
Jul 12, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

@AlanGriffiths AlanGriffiths commented Jul 3, 2024

Add a mir-kiosk-x11 package (to replace https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps)

The intended use is to include this from our release PPA to support snaps that wrap X11 apps. AFAICS there's no reason to also consider adding this to the Ubuntu archive.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (96738e0) to head (888f06b).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3460   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files        1076     1076           
  Lines       68922    68922           
=======================================
  Hits        53317    53317           
  Misses      15605    15605           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlanGriffiths AlanGriffiths marked this pull request as ready for review July 9, 2024 10:49
@AlanGriffiths AlanGriffiths requested a review from a team as a code owner July 9, 2024 10:49
@AlanGriffiths AlanGriffiths added the triaged Triage into JIRA to plan it in label Jul 11, 2024
@AlanGriffiths
Copy link
Collaborator Author

AFAICS there's no reason to also consider adding this to the Ubuntu archive.

For the archive, mir-demos is possibly the right place.

Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! LGTM.

debian/control Outdated
xwayland,
Description: Display server for Ubuntu - kiosk hosting X11 apps
.
Contains compositor that use the Mir display server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this seems to be a bit of a half description? Did this get cut off mid-thought?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm not blocking on that; feel free to expand, or hit the “merge” button)

@AlanGriffiths AlanGriffiths enabled auto-merge July 12, 2024 08:40
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit ae96ade Jul 12, 2024
33 of 36 checks passed
@AlanGriffiths AlanGriffiths deleted the x11-kiosk branch July 12, 2024 11:24
Saviq pushed a commit that referenced this pull request Aug 8, 2024
Add a mir-kiosk-x11 package (to replace
https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps)

The intended use is to include this from our release PPA to support
snaps that wrap X11 apps. AFAICS there's no reason to also consider
adding this to the Ubuntu archive.
@Saviq Saviq mentioned this pull request Aug 8, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2024
> Backport of #3460, #3480, #3486 to 2.16 for release into `core22`

Add a mir-kiosk-x11 package (to replace
https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps)

The intended use is to include this from our release PPA to support
snaps that wrap X11 apps. AFAICS there's no reason to also consider
adding this to the Ubuntu archive.
Saviq pushed a commit that referenced this pull request Aug 8, 2024
Add a mir-kiosk-x11 package (to replace
https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps)

The intended use is to include this from our release PPA to support
snaps that wrap X11 apps. AFAICS there's no reason to also consider
adding this to the Ubuntu archive.
@Saviq Saviq mentioned this pull request Aug 8, 2024
Saviq pushed a commit that referenced this pull request Aug 8, 2024
Add a mir-kiosk-x11 package (to replace
https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps)

The intended use is to include this from our release PPA to support
snaps that wrap X11 apps. AFAICS there's no reason to also consider
adding this to the Ubuntu archive.
Saviq pushed a commit that referenced this pull request Aug 8, 2024
Add a mir-kiosk-x11 package (to replace
https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps)

The intended use is to include this from our release PPA to support
snaps that wrap X11 apps. AFAICS there's no reason to also consider
adding this to the Ubuntu archive.
github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2024
> Backport of #3460, #3480, #3486 to 2.17 for release into `core22`

Add a mir-kiosk-x11 package (to replace
https://github.com/MirServer/mir_kiosk_x11.git in IOT snaps)

The intended use is to include this from our release PPA to support
snaps that wrap X11 apps. AFAICS there's no reason to also consider
adding this to the Ubuntu archive.
@AlanGriffiths AlanGriffiths mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Triage into JIRA to plan it in
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants