Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: BasicScreenShooter now selects a GLRenderingProvider based off of its compatibility with the BufferAllocator #3456

Merged
merged 1 commit into from
Jul 8, 2024
Merged

bugfix: BasicScreenShooter now selects a GLRenderingProvider based off of its compatibility with the BufferAllocator #3456

merged 1 commit into from
Jul 8, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Jul 2, 2024 •
edited
Loading

fixes: #3431

@mattkae
11;rgb:1717/1414/2121bugfix: BasicScreenShooter now selects a GLRende…
dcc38ab 
…ringProvider based off of its compatibility with the BufferAllocator
@mattkae mattkae force-pushed the bugfix/screen_shooter branch from 3c459f6 to dcc38ab Compare July 2, 2024 12:45
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.48%. Comparing base (317060e) to head (dcc38ab).
Report is 399 commits behind head on main.

Files with missing lines Patch % Lines
src/server/compositor/basic_screen_shooter.cpp 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3456      +/-   ##
==========================================
+ Coverage   77.45%   77.48%   +0.02%     
==========================================
  Files        1073     1074       +1     
  Lines       68782    69373     +591     
==========================================
+ Hits        53278    53751     +473     
- Misses      15504    15622     +118

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattkae mattkae requested a review from RAOF July 3, 2024 15:16
@mattkae mattkae marked this pull request as ready for review July 3, 2024 15:16
@mattkae mattkae requested a review from a team as a code owner July 3, 2024 15:16
@RAOF RAOF mentioned this pull request Jul 4, 2024
Closed
RAOF
RAOF approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot seem to reproduce the bug that this is should fix, so I can't test that it does fix it, but this looks right to me.

@mattkae mattkae added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit c751ed7 Jul 8, 2024
65 of 71 checks passed
@mattkae mattkae deleted the bugfix/screen_shooter branch July 8, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAOF RAOF RAOF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mattkae @RAOF