ForeignToplevelManagerV1 now reports hidden window handles instead of purposefully hiding them

[mattkae]

When we switch workspaces, foreign top level was reporting different windows, which doesn't seem right. The spec doesn't specify whether or not hidden windows should be reported.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.32%. Comparing base (9c643d3) to head (2eee09b).
Report is 438 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3380      +/-   ##
==========================================
- Coverage   77.34%   77.32%   -0.02%     
==========================================
  Files        1070     1070              
  Lines       68409    68409              
==========================================
- Hits        52909    52899      -10     
- Misses      15500    15510      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RAOF]

Urgh. This is another “I'm not against it as a practical improvement, but it's the wrong thing”. I think this wants a discussion about our window model next week.

[mattkae]

Urgh. This is another “I'm not against it as a practical improvement, but it's the wrong thing”. I think this wants a discussion about our window model next week.

I still think that this is a worthwhile bugfix until we actually refactor our entire window type system. It usefully fixes a strange bug

[RAOF]

Yeah, fair enough. This isn't going to impede doing a better job later!