actions: add step for checking miral and miroil symbols map #3336
Conversation
mattkae
force-pushed
the
feature/symbol_generator_ci
branch
from
cb3e542 to
57e1a4e
Compare
mattkae
force-pushed
the
feature/symbol_generator_ci
branch
from
fc2ff06 to
3223157
Compare
mattkae
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/symbols_generator #3336 +/- ##
=============================================================
+ Coverage 77.34% 77.35% +0.01%
=============================================================
Files 1062 1072 +10
Lines 67817 68216 +399
=============================================================
+ Hits 52453 52769 +316
- Misses 15364 15447 +83 ☔ View full report in Codecov by Sentry. |
mattkae
force-pushed
the
feature/symbol_generator_ci
branch
from
8808130 to
4d3eba4
Compare
This reverts commit 7169146.
.github/workflows/symbols-check.yml
Outdated
| - name: Install clang | ||
| run: | | ||
| wget https://apt.llvm.org/llvm.sh | ||
| chmod +x llvm.sh | ||
| sudo ./llvm.sh 19 |
There was a problem hiding this comment.
FWIW, this appears to work correctly with clang-19 from 24.04 (once that becomes available in GH, I guess)
.github/workflows/symbols-check.yml
Outdated
|
|
||
| - name: Install clang | ||
| run: | | ||
| wget https://apt.llvm.org/llvm.sh |
There was a problem hiding this comment.
Hm. What are the security concerns with this curl | sudo sh -?
It's in the GitHub runners infrastructure, so infrastructure escape shouldn't be a problem, but what does it have access to here?
I think the answer is that it's got access to the GitHub secrets? Which means it has access to the release signing key, and the signing key to upload to the PPA?
I don't think this should be a blocker here, but maybe we should record this somewhere?
There was a problem hiding this comment.
We changed this to at least add it from the repository
mattkae
force-pushed
the
feature/symbol_generator_ci
branch
10 times, most recently
from
5d2e82f to
6ba8032
Compare
mattkae
force-pushed
the
feature/symbol_generator_ci
branch
from
6ba8032 to
0ab1bdb
Compare
…ing exit(1) Co-authored-by: Michał Sawicz <[email protected]>
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| sudo apt-get build-dep ./ |
There was a problem hiding this comment.
This is the expensive step :)
| sudo apt-get build-dep ./ |
There was a problem hiding this comment.
I want the build deps so that 3rd party libraries resolve in clang, right?
Co-authored-by: Michał Sawicz <[email protected]>
No description provided.