Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: publishing mirtest-internal to provide access to all mock/stub files for testing #3333

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Apr 16, 2024

fixes #3283

@mattkae mattkae changed the title Feature/mirtest internal dev WIP: feature: publishing mirtest-internal to provide access to all mock/stub files for testing Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (4128d65) to head (3c3e77d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3333    +/-   ##
========================================
  Coverage   77.52%   77.53%            
========================================
  Files        1065     1075    +10     
  Lines       67869    68268   +399     
========================================
+ Hits        52618    52931   +313     
- Misses      15251    15337    +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattkae mattkae force-pushed the feature/mirserver-internal-dev branch 3 times, most recently from ae3dc53 to 948f24a Compare April 24, 2024 17:39
Base automatically changed from feature/mirserver-internal-dev to main April 25, 2024 13:31
@mattkae mattkae force-pushed the feature/mirtest-internal-dev branch from 475c9a0 to 6e9cea3 Compare April 25, 2024 18:29
@mattkae mattkae changed the title WIP: feature: publishing mirtest-internal to provide access to all mock/stub files for testing feature: publishing mirtest-internal to provide access to all mock/stub files for testing Apr 26, 2024
@mattkae mattkae marked this pull request as ready for review April 26, 2024 19:26
@mattkae mattkae requested a review from a team as a code owner April 26, 2024 19:26
@mattkae mattkae requested a review from AlanGriffiths April 26, 2024 19:58
@mattkae mattkae force-pushed the feature/mirtest-internal-dev branch from 95c0856 to 9feda44 Compare May 1, 2024 20:07
@mattkae mattkae force-pushed the feature/mirtest-internal-dev branch from 9feda44 to 3c3e77d Compare May 1, 2024 20:14
@AlanGriffiths
Copy link
Collaborator

@mattkae it is now unclear what happened to fail the test builds: Should we revive this PR or park it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish mir*-internal libraries
2 participants