Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the glog example - nobody uses it #3330

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Drop the glog example - nobody uses it #3330

merged 1 commit into from
Apr 12, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

Fixes: #3318

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner April 12, 2024 10:56
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.41%. Comparing base (79cd71c) to head (9581984).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
+ Coverage   77.39%   77.41%   +0.01%     
==========================================
  Files        1064     1062       -2     
  Lines       68075    68049      -26     
==========================================
- Hits        52689    52679      -10     
+ Misses      15386    15370      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh? How was this in platform's symbols.map…?

@Saviq Saviq added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit 8407da2 Apr 12, 2024
35 of 36 checks passed
@Saviq Saviq deleted the drop-glog branch April 12, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTBFS since google-glog v0.7.0
2 participants