Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msd::Renderer: Use freetype error return value #3329

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

RAOF
Copy link
Contributor

@RAOF RAOF commented Apr 12, 2024

Clang has started (correctly) identifying that we're not using the error variable we're declaring. We might as well!

Clang has started (correctly) identifying that we're not using the error variable
we're declaring. We might as well!
@RAOF RAOF requested a review from a team as a code owner April 12, 2024 08:16
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 77.39%. Comparing base (ed32a17) to head (e80bcf1).
Report is 16 commits behind head on main.

Files Patch % Lines
src/server/shell/decoration/renderer.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3329      +/-   ##
==========================================
- Coverage   77.41%   77.39%   -0.03%     
==========================================
  Files        1074     1064      -10     
  Lines       68471    68080     -391     
==========================================
- Hits        53008    52690     -318     
+ Misses      15463    15390      -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful, and can't hurt

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Apr 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2024
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit f30fd9e Apr 12, 2024
32 of 35 checks passed
@AlanGriffiths AlanGriffiths deleted the use-freetype-error-return branch April 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants