Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: expose existing input configuration options #3315

Closed
wants to merge 12 commits into from

Conversation

AlanGriffiths
Copy link
Collaborator

@AlanGriffiths AlanGriffiths commented Apr 3, 2024

I don't intend to land this in its current form. But it allows me to experiment with the input configuration

@AlanGriffiths AlanGriffiths changed the base branch from main to fix-doxygen-config April 3, 2024 16:58
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 53.53535% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 77.51%. Comparing base (1508246) to head (b3f3617).

Current head b3f3617 differs from pull request most recent head 4565029

Please upload reports for the commit 4565029 to get more accurate results.

Files Patch % Lines
src/miral/input_device_config.cpp 50.53% 46 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3315   +/-   ##
=======================================
  Coverage   77.50%   77.51%           
=======================================
  Files        1065     1064    -1     
  Lines       67914    67895   -19     
=======================================
- Hits        52638    52630    -8     
+ Misses      15276    15265   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from fix-doxygen-config to main April 3, 2024 18:42
@AlanGriffiths AlanGriffiths force-pushed the spike/input-configuration branch 2 times, most recently from ed1e2bd to 730a81c Compare April 5, 2024 11:48
@AlanGriffiths AlanGriffiths force-pushed the spike/input-configuration branch from 730a81c to 15586ef Compare April 15, 2024 16:23
@AlanGriffiths AlanGriffiths force-pushed the spike/input-configuration branch from 13f8acd to 149a531 Compare April 23, 2024 16:43
@AlanGriffiths AlanGriffiths force-pushed the spike/input-configuration branch 3 times, most recently from d5fc217 to b3f3617 Compare May 8, 2024 07:13
@AlanGriffiths AlanGriffiths force-pushed the spike/input-configuration branch from b3f3617 to e5a7a16 Compare May 21, 2024 13:47
@AlanGriffiths AlanGriffiths force-pushed the spike/input-configuration branch from e5a7a16 to 646b3a9 Compare May 30, 2024 13:55
@AlanGriffiths AlanGriffiths force-pushed the spike/input-configuration branch from 646b3a9 to 4565029 Compare May 31, 2024 10:52
@Saviq
Copy link
Collaborator

Saviq commented Jun 11, 2024

This can be closed?

@AlanGriffiths
Copy link
Collaborator Author

This can be closed?

Yes

@AlanGriffiths AlanGriffiths deleted the spike/input-configuration branch June 11, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants