Fix skipping of ExternalClient tests when environment doesn't support X11 #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3138 +/- ##
=======================================
Coverage 77.82% 77.83%
=======================================
Files 1064 1064
Lines 74410 74412 +2
=======================================
+ Hits 57913 57917 +4
+ Misses 16497 16495 -2 ☔ View full report in Codecov by Sentry. |
Saviq
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Locally looks good, testing in the PPA here:
https://launchpad.net/~mir-team/+archive/ubuntu/test/+packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @hbatagelo who mentioned this in #3133