Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting the egl-generic rendering platform to the end of the list #3122

Closed
wants to merge 2 commits into from

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Nov 10, 2023

Fixes #3112

How to test

  • Get access to an nvidia hybrid platform
  • Run sudo XDG_RUNTIME_DIR=/run ./bin/mir_performance_tests --gtest_filter=GLMark2Wayland.* and it should all work

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #3122 (78c0c60) into main (4c131c1) will decrease coverage by 0.04%.
Report is 10 commits behind head on main.
The diff coverage is 20.00%.

❗ Current head 78c0c60 differs from pull request most recent head 46d0f18. Consider uploading reports for the commit 46d0f18 to get more accurate results

@@            Coverage Diff             @@
##             main    #3122      +/-   ##
==========================================
- Coverage   77.84%   77.81%   -0.04%     
==========================================
  Files        1064     1064              
  Lines       74389    74418      +29     
==========================================
  Hits        57907    57907              
- Misses      16482    16511      +29     
Files Coverage Δ
src/server/graphics/default_configuration.cpp 76.82% <20.00%> (-2.65%) ⬇️

... and 25 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@mattkae mattkae force-pushed the bugfix/3112 branch 2 times, most recently from f469563 to 014874d Compare November 10, 2023 10:02
@mattkae mattkae changed the title Prioritizing the best rendering platform over all supported rendering platforms Removing the egl-generic rendering platform from the supported list if another platform is available Nov 10, 2023
@mattkae mattkae requested a review from Saviq November 10, 2023 10:03
@mattkae mattkae marked this pull request as ready for review November 10, 2023 10:04
@mattkae mattkae changed the title Removing the egl-generic rendering platform from the supported list if another platform is available Sorting the egl-generic rendering platform to the end of the list Nov 10, 2023
@mattkae mattkae force-pushed the bugfix/3112 branch 4 times, most recently from 2887b30 to 180e9a7 Compare November 10, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to query Wayland buffer format: EGL_SUCCESS (0x3000) in performance tests on Nvidia
1 participant