Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the Wayland platform failing to use GenericEGLDisplayProvider::Tag in maybe_create_provider #3121

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Nov 8, 2023

No description provided.

Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #3121 (9c57f3e) into main (5a9c122) will increase coverage by 0.01%.
Report is 8 commits behind head on main.
The diff coverage is 43.56%.

@@            Coverage Diff             @@
##             main    #3121      +/-   ##
==========================================
+ Coverage   77.82%   77.83%   +0.01%     
==========================================
  Files        1064     1064              
  Lines       74408    74389      -19     
==========================================
- Hits        57906    57900       -6     
+ Misses      16502    16489      -13     
Files Coverage Δ
include/platform/mir/graphics/platform.h 84.84% <100.00%> (-0.45%) ⬇️
src/platforms/common/server/kms_framebuffer.h 100.00% <ø> (ø)
...latforms/eglstream-kms/server/platform_symbols.cpp 16.06% <100.00%> (ø)
src/platforms/gbm-kms/server/kms/display_buffer.h 100.00% <ø> (ø)
...latforms/renderer-generic-egl/platform_symbols.cpp 83.78% <100.00%> (ø)
...tforms/renderer-generic-egl/rendering_platform.cpp 83.33% <100.00%> (ø)
src/platforms/virtual/platform.cpp 100.00% <100.00%> (+31.91%) ⬆️
src/platforms/virtual/platform.h 100.00% <ø> (ø)
src/platforms/wayland/platform.cpp 80.00% <100.00%> (+1.73%) ⬆️
src/platforms/wayland/platform.h 100.00% <ø> (ø)
... and 42 more

... and 4 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@mattkae mattkae changed the title Fix for the hosted wayland test Fox for the Wayland platform failing to use GenericEGLDisplayProvider::Tag in maybe_create_provider Nov 8, 2023
@mattkae mattkae marked this pull request as ready for review November 8, 2023 11:38
@mattkae mattkae force-pushed the bugfix/hosted_wayland_test branch from 2dc4ddb to 1555dbb Compare November 8, 2023 11:39
@mattkae mattkae enabled auto-merge November 8, 2023 11:39
@mattkae mattkae added this pull request to the merge queue Nov 8, 2023
@mattkae mattkae removed this pull request from the merge queue due to a manual request Nov 8, 2023
@mattkae mattkae changed the title Fox for the Wayland platform failing to use GenericEGLDisplayProvider::Tag in maybe_create_provider Fix for the Wayland platform failing to use GenericEGLDisplayProvider::Tag in maybe_create_provider Nov 8, 2023
@mattkae mattkae force-pushed the bugfix/hosted_wayland_test branch from 1555dbb to 9c57f3e Compare November 8, 2023 12:21
@mattkae mattkae enabled auto-merge November 8, 2023 12:21
@mattkae mattkae added this pull request to the merge queue Nov 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2023
@mattkae mattkae added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 9, 2023
@Saviq Saviq added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 4c131c1 Nov 9, 2023
@Saviq Saviq deleted the bugfix/hosted_wayland_test branch November 9, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants