Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold the rendering platforms in description->name order #3085

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

AlanGriffiths
Copy link
Collaborator

Make the choice of buffer allocator determanistic and prefer "eglstream" over "gbm".

I think this resolves the problem as I understand it, but I don't have easy access to hardware to verify my understanding.

…tream over gbm when choosing a buffer allocator
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #3085 (18ba177) into main (182bf7c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 18ba177 differs from pull request most recent head d1c0d09. Consider uploading reports for the commit d1c0d09 to get more accurate results

@@           Coverage Diff           @@
##             main    #3085   +/-   ##
=======================================
  Coverage   78.44%   78.45%           
=======================================
  Files        1064     1064           
  Lines       74430    74434    +4     
=======================================
+ Hits        58388    58395    +7     
+ Misses      16042    16039    -3     
Files Coverage Δ
src/server/graphics/default_configuration.cpp 80.99% <100.00%> (+0.31%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…er eglstream over gbm when choosing a buffer allocator
@AlanGriffiths AlanGriffiths force-pushed the prefer-eglstream-buffer-allocator branch from a06745d to d1c0d09 Compare October 19, 2023 15:19
@AlanGriffiths AlanGriffiths self-assigned this Oct 19, 2023
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

@Saviq Saviq enabled auto-merge October 19, 2023 19:11
@Saviq Saviq added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit 9404475 Oct 20, 2023
31 of 33 checks passed
@Saviq Saviq deleted the prefer-eglstream-buffer-allocator branch October 20, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants