Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming for rendering classes, functions and variables #3079

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

AlanGriffiths
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #3079 (79622a9) into platform-API-merge (a77df47) will increase coverage by 0.02%.
The diff coverage is 70.00%.

@@                  Coverage Diff                   @@
##           platform-API-merge    #3079      +/-   ##
======================================================
+ Coverage               75.91%   75.94%   +0.02%     
======================================================
  Files                    1058     1058              
  Lines                   74084    74005      -79     
======================================================
- Hits                    56239    56200      -39     
+ Misses                  17845    17805      -40     
Files Coverage Δ
include/platform/mir/graphics/platform.h 85.29% <100.00%> (ø)
...tforms/renderer-generic-egl/rendering_platform.cpp 80.28% <100.00%> (ø)
src/server/compositor/default_configuration.cpp 96.42% <100.00%> (ø)
...lude/mir/test/doubles/mock_gl_rendering_provider.h 60.00% <ø> (ø)
...lude/mir/test/doubles/stub_gl_rendering_provider.h 86.95% <ø> (ø)
...ation-tests/test_surface_stack_with_compositor.cpp 94.41% <ø> (ø)
tests/mir_test_framework/headless_test.cpp 88.23% <100.00%> (ø)
...s/mir_test_framework/stubbed_graphics_platform.cpp 83.67% <100.00%> (ø)
tests/mir_test_framework/test_display_server.cpp 87.50% <100.00%> (ø)
...nit-tests/compositor/test_basic_screen_shooter.cpp 93.15% <ø> (ø)
... and 7 more

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree that's better.

@RAOF RAOF merged commit 72b1738 into platform-API-merge Oct 16, 2023
29 of 30 checks passed
@RAOF RAOF deleted the platform-API-merge-rename branch October 16, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants