Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: actually run performance tests #3077

Merged
merged 5 commits into from
Oct 19, 2023
Merged

coverage: actually run performance tests #3077

merged 5 commits into from
Oct 19, 2023

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Oct 13, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #3077 (0090033) into main (0cb0178) will increase coverage by 0.90%.
Report is 154 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3077      +/-   ##
==========================================
+ Coverage   77.67%   78.57%   +0.90%     
==========================================
  Files        1056     1075      +19     
  Lines       73473    80100    +6627     
==========================================
+ Hits        57070    62940    +5870     
- Misses      16403    17160     +757     

see 162 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Saviq Saviq marked this pull request as draft October 18, 2023 13:03
@Saviq Saviq marked this pull request as ready for review October 18, 2023 13:03
Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We should keep an eye on whether the performance tests fail due to resource starvation (they're not super intensive, but who knows how much real CPU the CI runners get?), but they haven't been failing here.

@RAOF RAOF added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 182bf7c Oct 19, 2023
62 of 64 checks passed
@RAOF RAOF deleted the coverage-performance branch October 19, 2023 00:57
@Saviq
Copy link
Collaborator Author

Saviq commented Oct 19, 2023

We should keep an eye on whether the performance tests fail due to resource starvation (they're not super intensive, but who knows how much real CPU the CI runners get?), but they haven't been failing here.

There actually is a vGPU there, so we should be fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants