Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature flag to hide hybrid capability #3072

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

AlanGriffiths
Copy link
Collaborator

The intent is to allows us to merge without exposing functionality we are still polishing.

This uses an environment variable (MIR_EXPERIMENTAL_HYBRID_GRAPHICS), not a configuration option, as that is easy to drop seamlessly later.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #3072 (dbef651) into platform-API-merge (839a0aa) will increase coverage by 0.03%.
The diff coverage is 88.88%.

@@                  Coverage Diff                   @@
##           platform-API-merge    #3072      +/-   ##
======================================================
+ Coverage               75.79%   75.82%   +0.03%     
======================================================
  Files                    1057     1057              
  Lines                   73992    73922      -70     
======================================================
- Hits                    56079    56052      -27     
+ Misses                  17913    17870      -43     
Files Coverage Δ
src/server/graphics/default_configuration.cpp 79.57% <88.88%> (+0.37%) ⬆️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlanGriffiths
Copy link
Collaborator Author

::   147 |         platform_modules.resize(std::min(1ul, platform_modules.size()));
::       |                                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Rats! I wrote "1uz" and the compiler complained that I was using c++23.

@AlanGriffiths AlanGriffiths marked this pull request as ready for review October 12, 2023 09:11
@AlanGriffiths AlanGriffiths requested a review from Saviq October 12, 2023 09:11
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesomes.

@Saviq Saviq merged commit 55c9c91 into platform-API-merge Oct 12, 2023
30 of 49 checks passed
@Saviq Saviq deleted the platform-API-merge-feature-flag branch October 12, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants