Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up "frontend" #3061

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Tidy up "frontend" #3061

merged 1 commit into from
Oct 5, 2023

Conversation

AlanGriffiths
Copy link
Collaborator

If we were to need a generic frontend we would need to rework stuff anyway. So no need to keep the last bit separate

@AlanGriffiths AlanGriffiths requested a review from mattkae October 4, 2023 13:28
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #3061 (91589a6) into main (85bc5b0) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3061   +/-   ##
=======================================
  Coverage   77.69%   77.69%           
=======================================
  Files        1056     1056           
  Lines       73409    73409           
=======================================
+ Hits        57037    57038    +1     
+ Misses      16372    16371    -1     
Files Coverage Δ
...rc/server/frontend_wayland/session_credentials.cpp 45.45% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the CI break is on your end, but the project builds and makes sense to me 👍

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 71c20b7 Oct 5, 2023
33 checks passed
@AlanGriffiths AlanGriffiths deleted the tidy-frontend branch October 5, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants