Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the demo client to use xdg-shell #3060

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Rework the demo client to use xdg-shell #3060

merged 3 commits into from
Oct 5, 2023

Conversation

AlanGriffiths
Copy link
Collaborator

Also:

  • give better errors when the compositor doesn't support required extensions; and,
  • allows compositor to resize windows

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #3060 (706ebe8) into main (85bc5b0) will decrease coverage by 0.01%.
The diff coverage is 85.52%.

@@            Coverage Diff             @@
##             main    #3060      +/-   ##
==========================================
- Coverage   77.69%   77.69%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       73409    73449      +40     
==========================================
+ Hits        57037    57066      +29     
- Misses      16372    16383      +11     
Files Coverage Δ
examples/client/wayland_client.c 75.00% <85.52%> (-0.79%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mattkae mattkae self-requested a review October 4, 2023 14:34
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the meaning of min versions there. However, I tested it and the rest looks good 👍

examples/client/wayland_client.c Show resolved Hide resolved
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one question is answered 👍 Works well on my end

@mattkae mattkae added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit ba097f7 Oct 5, 2023
33 checks passed
@mattkae mattkae deleted the update-demo-client branch October 5, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants