Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .mailmap file to map old commits to Sophie's new name and email #3057

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

wmww
Copy link
Contributor

@wmww wmww commented Sep 30, 2023

Hi!

My old name is all over Mir git history. I don't care that much so I never proposed filter-branching it out, but I recently found out with a simple .mailmap you can get a lot of the same benefits without changing history. If this is merged my new name will be displayed on my old commits and on git blame, both locally and on github.

@wmww
Copy link
Contributor Author

wmww commented Sep 30, 2023

If this isn't objectionable I might make similar PRs to a bunch of the other Mir team repos I contributed to.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #3057 (bed6d79) into main (6e2dc72) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
- Coverage   77.70%   77.70%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       73409    73409              
==========================================
- Hits        57042    57040       -2     
- Misses      16367    16369       +2     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Saviq
Copy link
Collaborator

Saviq commented Sep 30, 2023

Hey o/, can you point at documentation on what respects this?

Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but @Saviq has a question before we land

@wmww
Copy link
Contributor Author

wmww commented Oct 8, 2023

Sorry, off GH for a while.

Git docs here: https://git-scm.com/docs/gitmailmap

I can't find any sort of official github docs but this stack overflow says it works: https://stackoverflow.com/questions/53629125/does-github-consider-mailmap-for-contribution-graph

@Saviq Saviq added this pull request to the merge queue Oct 8, 2023
Merged via the queue into main with commit bc4d39a Oct 8, 2023
32 checks passed
@Saviq Saviq deleted the sophie-mailmap branch October 8, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants