Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid undefined behavior #3055

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Avoid undefined behavior #3055

merged 1 commit into from
Oct 3, 2023

Conversation

AlanGriffiths
Copy link
Collaborator

We don't guarantee that XKBMapper::map_event() sets last_device_id before we use it in XKBMapper::update_modifier() and valgrind complains.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #3055 (850d34b) into main (076ebfd) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3055      +/-   ##
==========================================
- Coverage   77.70%   77.69%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       73409    73409              
==========================================
- Hits        57041    57037       -4     
- Misses      16368    16372       +4     
Files Coverage Δ
src/common/input/xkb_mapper.cpp 78.83% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yups.

@Saviq Saviq added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 85bc5b0 Oct 3, 2023
32 checks passed
@Saviq Saviq deleted the pacify-valgrind branch October 3, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants