Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for ancient gtest versions #3038

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

AlanGriffiths
Copy link
Collaborator

No description provided.

@AlanGriffiths AlanGriffiths requested a review from Saviq September 11, 2023 15:04
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #3038 (cc70a5c) into main (4dd5338) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3038      +/-   ##
==========================================
- Coverage   77.70%   77.70%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       73394    73394              
==========================================
- Hits        57034    57031       -3     
- Misses      16360    16363       +3     
Files Changed Coverage Δ
tests/include/mir/test/input_config_matchers.h 78.04% <ø> (ø)
tests/unit-tests/graphics/test_shm_buffer.cpp 94.94% <ø> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this blends, it blends!

@Saviq Saviq enabled auto-merge September 11, 2023 15:44
@Saviq Saviq added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit afb3f93 Sep 11, 2023
20 of 21 checks passed
@Saviq Saviq deleted the drop-obsolete-gtest-version-hackery branch September 11, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants