Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify mmap interception #3027

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Simplify mmap interception #3027

merged 3 commits into from
Aug 31, 2023

Conversation

AlanGriffiths
Copy link
Collaborator

No description provided.

@AlanGriffiths
Regardless of any preprocessing "magic" done to the mmap symbol, we…
ad2d28d 
… can get the actual name of the function using `__func__`.
@AlanGriffiths AlanGriffiths changed the title Simpli Simplify mmap interception Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #3027 (da806f6) into main (5406500) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #3027      +/-   ##
==========================================
- Coverage   77.70%   77.70%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       73394    73393       -1     
==========================================
- Hits        57033    57032       -1     
  Misses      16361    16361
Files Changed Coverage Δ
tests/mir_test_framework/mmap_wrapper.cpp 71.42% <66.66%> (-1.30%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlanGriffiths AlanGriffiths marked this pull request as ready for review August 30, 2023 16:23
@Saviq
Copy link
Collaborator

Saviq commented Aug 31, 2023

Building in a PPA here:

https://launchpad.net/~saviq/+archive/ubuntu/ppa/+sourcepub/15134955/+listing-archive-extra

@Saviq Saviq requested a review from RAOF August 31, 2023 09:04
RAOF
RAOF approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah. That's a neat trick.

@RAOF RAOF added this pull request to the merge queue Aug 31, 2023
@RAOF RAOF removed this pull request from the merge queue due to a manual request Aug 31, 2023
@RAOF RAOF added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit 82c6c01 Aug 31, 2023
30 of 40 checks passed
@RAOF RAOF deleted the tidy_up branch August 31, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saviq Saviq Saviq left review comments

@RAOF RAOF RAOF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGriffiths @Saviq @RAOF