ci: run tests in ubsan #3025
Merged
ci: run tests in ubsan #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default UBSan will log-and-continue when UB is detected. This results in log messages, but doesn't change the exit code of the program. This is unhelpful for CI, where we want *failures* on UB. Set UBSan to immediately kill the program whenever UB is detected, so CI passes imply no-UB-detected.
Codecov Report
@@ Coverage Diff @@
## main #3025 +/- ##
=======================================
Coverage 77.70% 77.71%
=======================================
Files 1056 1056
Lines 73394 73394
=======================================
+ Hits 57033 57038 +5
+ Misses 16361 16356 -5 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D'oh.