bugfix: always sending an initial output enter if we fail to send one…

… otherwise

src/include/server/mir/scene/surface.h

@@ -49,6 +49,9 @@ class Surface :
     public ObserverRegistrar<SurfaceObserver>
 {
 public:
+    /// Called after the initial position and size has been set for the surface
+    virtual void advise_created() = 0;
+
     // resolve ambiguous member function names
 
     std::string name() const override = 0;

src/server/scene/basic_surface.cpp

@@ -281,6 +281,11 @@ void ms::BasicSurface::unregister_interest(SurfaceObserver const& observer)
     observers->unregister_interest(observer);
 }
 
+void ms::BasicSurface::advise_created()
+{
+    linearised_track_outputs();
+}
+
 std::string ms::BasicSurface::name() const
 {
     return synchronised_state.lock()->surface_name;

src/server/scene/basic_surface.h

@@ -87,6 +87,7 @@ class BasicSurface : public Surface
     void register_early_observer(std::weak_ptr<SurfaceObserver> const& observer, Executor& executor) override;
     void unregister_interest(SurfaceObserver const& observer) override;
 
+    virtual void advise_created() override;
     std::string name() const override;
     void move_to(geometry::Point const& top_left) override;
 

src/server/shell/abstract_shell.cpp

@@ -262,6 +262,8 @@ auto msh::AbstractShell::create_surface(
     {
         decoration_manager->decorate(result);
     }
+
+    result->advise_created();
     return result;
 }
 

tests/include/mir/test/doubles/stub_surface.h

@@ -28,6 +28,7 @@ namespace doubles
 // scene::Surface is a horribly wide interface to expose from Mir
 struct StubSurface : scene::Surface
 {
+    void advise_created() override { }
     std::string name() const override { return ""; }
     void move_to(geometry::Point const&) override {}
     geometry::Size window_size() const override { return {}; }