Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make vite dev server port configurable #1060

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Jan 17, 2025

Done

  • Make vite dev server port configurable. It is set to 3000 by default so we don't need to worry about creating an extra secret for the demo environment.
  • Added to the docs about configuring VITE_PORT

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Ensure CI passes
    • Check starting the local dev environment and the UI loads
    • Check the demo server and make sure UI loads

@webteam-app
Copy link

lorumic
lorumic previously approved these changes Jan 17, 2025
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor ideas :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
lorumic
lorumic previously approved these changes Jan 20, 2025
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change - LGTM 👍

.env Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
vite.config.ts Outdated Show resolved Hide resolved
@edlerd
Copy link
Collaborator

edlerd commented Jan 20, 2025

Thanks for bringing this up so quickly, some suggestions from review above.

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks for adjusting it :)

@mas-who mas-who merged commit 979d3da into canonical:main Jan 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants