feat: [WD-17984] Add Pure Storage

[Kxiru]

Done

• Added Pure Storage functionality

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
   • With a local copy of this branch, build and run as described in the docs.
2. Perform the following QA steps:
   • Check out the branch and in the env.local file (One must be created if it does not already exist) add this line of code LXD_UI_BACKEND_IP=10.239.7.201 to have LXD point to the Pure-Storage-supported server. One must also have the Canonical vpn running to access this.
   • Please message @Kxiru for API Token and Gateway Credentials.
   • Navigate to Create a new storage pool and attempt to create a pool with Driver set to "Pure Storage" and "Verify Gateway" set to False (If set to True, this will fail).
   • Navigate to storage volumes and attempt to create a sotrage volume and assign it to the "Pure storage" pool just created.

Screenshots

[webteam-app]

Demo

Jenkins

demos.haus

[edlerd]

Some small suggestions on the copy. Code seems all right.

[edlerd]

To resolve the test failures, please rebase on latest state of the main branch.

[edlerd]

Code LGTM, @mas-who I think you also have a token, can you please do QA?

[mas-who]

Some QA issues:

1. After creating a pure storage pool, navigating to the config page for that pool, some of the config fields are not displaying existing values e.g. api token, api gateway etc
   

2. On the edit page for pure storage pool, updates made to api token, api gateway, verify gateway and mode fields does not persist

3. After creating a pure storage volume, navigating to its config page for the first time, update a config without saving. The save button shows "Save 3 changes", but only one config has been altered. I checked the same for a zfs storage volume, the problem didn't occur, so this seems to be specific to pure storage volume updates.
   Screencast from 10-01-2025 18:25:13.webm

[Kxiru]

Some QA issues:

1. After creating a pure storage pool, navigating to the config page for that pool, some of the config fields are not displaying existing values e.g. api token, api gateway etc
   ...

Thanks for this QA, Mason, that would have been a serious oversight. I think I have identified and addressed the problem now, and it actually related to all 3 of your concerns. Please verify from your end.

[mas-who]

Some QA issues:

1. After creating a pure storage pool, navigating to the config page for that pool, some of the config fields are not displaying existing values e.g. api token, api gateway etc
   ...

Thanks for this QA, Mason, that would have been a serious oversight. I think I have identified and addressed the problem now, and it actually related to all 3 of your concerns. Please verify from your end.

Can confirm 1 and 2 are resolved now. It seems that 3 is still happening (see screenshot below), changing any volume config results in the save button to show "3" changes.

[Kxiru]

Some QA issues:

1. After creating a pure storage pool, navigating to the config page for that pool, some of the config fields are not displaying existing values e.g. api token, api gateway etc
   ...

Thanks for this QA, Mason, that would have been a serious oversight. I think I have identified and addressed the problem now, and it actually related to all 3 of your concerns. Please verify from your end.

Can confirm 1 and 2 are resolved now. It seems that 3 is still happening (see screenshot below), changing any volume config results in the save button to show "3" changes. ...

Ah, apologies, I thought you had been seeing the error on the storage pool page, not the storage volume page. I'll push a fix for this shortly.

[mas-who]

LGTM 👍