-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set charm status to waiting if ingress is not ready or if the 2 ingresses have conflicting path #127
base: main
Are you sure you want to change the base?
Conversation
Test coverage for 023050f
Static code analysis report
|
Is this missing some context for the reason for this change please? |
"""Indicate whether ingress is properly configured. | ||
|
||
Returns: | ||
A tuple of a bool indicating whether ingress is configured and the reason if not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about making this a named tuple so that we don't have to assign meaning to indexes of the tuple implicitly?
A tuple of a bool indicating whether ingress is configured and the reason if not. | ||
""" | ||
if not self.ingress_observer.is_ingress_ready(): | ||
return (False, "Missing ingress relation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the ingress integration always required?
Checklist
src-docs
urgent
,trivial
,complex
)