Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --enable-multi-window option and refactor runner code #12

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

hbatagelo
Copy link

This pull request is the framework counterpart of canonical/flutter-engine#1. It introduces the --enable-multi-window command-line option to flutter tools and updates the runner code of the reference application to align with the refactored Windows embedder.

Updated Steps for Running the Reference App

Prerequisites

  • Build a custom engine using the refactored embedder
    (The following assumes the engine is built in debug mode)

Run with flutter run --enable-multi-window

cd <path_to_flutter>\examples\multi_window_ref_app
flutter run --enable-multi-window --debug --local-engine-src-path <path_to_custom_engine> --local-engine host_debug_unopt --local-engine-host host_debug_unopt lib/main.dart

Build and run manually

  1. Build the application:
cd <path_to_flutter>\examples\multi_window_ref_app
flutter build windows --debug --local-engine-src-path <path_to_custom_engine> --local-engine host_debug_unopt --local-engine-host host_debug_unopt lib/main.dart
  1. Set environment variables and run the executable:
set FLUTTER_ENGINE_SWITCHES=1
set FLUTTER_ENGINE_SWITCH_1=enable-multi-window=true
.\build\windows\x64\runner\Debug\multi_window_ref_app.exe

Copy link

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me!

Copy link

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattkae mattkae merged commit 8dead54 into foundation Dec 16, 2024
1 check passed
@mattkae mattkae deleted the add-command-line-option branch December 16, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants