In replication scenario, entry_sm gets updated every time it is used.

[just-now]

It's not expected that the reference to the entry is taken in all places in the code. That's why every time it's accessed without taking a reference it's needed to save term and index of the entry to access it later through log_get_entry_sm().

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (36eac86) to head (631183e).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   74.02%   81.15%   +7.13%     
==========================================
  Files         192      196       +4     
  Lines       27827    29563    +1736     
  Branches     2797     4090    +1293     
==========================================
+ Hits        20598    23993    +3395     
+ Misses       4906     3906    -1000     
+ Partials     2323     1664     -659     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[letFunny]

Thanks for this Anatoliy, I just left a comment that hopefully makes the intent more clear and makes it harder for people to misuse it in the future.