Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url check to include redirect #74

Merged
merged 8 commits into from
Jan 24, 2023
Merged

Conversation

jdkandersson
Copy link
Contributor

Closes #40

  • Adds an additional check to ensure that the topic URL resolves on discourse
  • Relaxes the URL checks to be after any redirects

@jdkandersson jdkandersson requested a review from a team as a code owner January 23, 2023 05:51
@jdkandersson
Copy link
Contributor Author

There seems to be a problem, changing this to draft for now

@jdkandersson jdkandersson marked this pull request as draft January 23, 2023 05:57
@jdkandersson jdkandersson marked this pull request as ready for review January 23, 2023 06:25
@jdkandersson
Copy link
Contributor Author

Issue fixed, ready for review

Copy link

@gregory-schiano gregory-schiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arturo-seijas
arturo-seijas previously approved these changes Jan 24, 2023
Copy link
Contributor

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do something about the docker linter suggestion?

merkata
merkata previously approved these changes Jan 24, 2023
@jdkandersson jdkandersson dismissed stale reviews from merkata and arturo-seijas via be685e5 January 24, 2023 11:51
@jdkandersson
Copy link
Contributor Author

Had to merge changes from main, another review please

@github-actions
Copy link

Test coverage for be685e5

Name                      Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------
src/__init__.py              42      0      6      0   100%
src/action.py               128      0     36      0   100%
src/discourse.py            147      0     32      0   100%
src/docs_directory.py        29      0      8      0   100%
src/exceptions.py            11      0      0      0   100%
src/index.py                 30      0      6      0   100%
src/metadata.py              28      0     12      0   100%
src/migration.py            106      0     35      0   100%
src/navigation_table.py      53      0     16      0   100%
src/pull_request.py          88      0     16      0   100%
src/reconcile.py             66      0     34      0   100%
src/types_.py               123      0     22      0   100%
---------------------------------------------------------------------
TOTAL                       851      0    223      0   100%

Static code analysis report

Run started:2023-01-24 11:54:13.442706

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 8023
  Total lines skipped (#nosec): 16
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link

@gtrkiller gtrkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@gregory-schiano gregory-schiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdkandersson jdkandersson merged commit 137bf75 into main Jan 24, 2023
@jdkandersson jdkandersson deleted the url-check-to-include-redirect branch January 24, 2023 23:42
@jdkandersson
Copy link
Contributor Author

jdkandersson commented Jan 25, 2023

Can we do something about the docker linter suggestion?

Thanks for the prompt, I didn't see the comment before merging. This action's use of docker has some opportunities for improvement I have been thinking about. The docker build takes a considerable amount of time now and it would be good to just have an image for the action stored somewhere so it doesn't have to be built every time. This isn't a simple change because it also means that the testing needs to be changed and increases the complexity of releases and the workflow for pull requests. I'll add an issue to improve the use of docker which we can eventually get to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discourse.topic_url_valid is too fussy
6 participants