-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url check to include redirect #74
Conversation
There seems to be a problem, changing this to draft for now |
Issue fixed, ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do something about the docker linter suggestion?
be685e5
Had to merge changes from main, another review please |
Test coverage for be685e5
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the prompt, I didn't see the comment before merging. This action's use of docker has some opportunities for improvement I have been thinking about. The docker build takes a considerable amount of time now and it would be good to just have an image for the action stored somewhere so it doesn't have to be built every time. This isn't a simple change because it also means that the testing needs to be changed and increases the complexity of releases and the workflow for pull requests. I'll add an issue to improve the use of docker which we can eventually get to.
|
Closes #40