Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow slashes in partition names #1002

Merged
merged 1 commit into from
Feb 6, 2025
Merged

feat: Allow slashes in partition names #1002

merged 1 commit into from
Feb 6, 2025

Conversation

upils
Copy link
Contributor

@upils upils commented Feb 3, 2025 •
edited
Loading

  • Have you signed the CLA?
  • Have you added an entry to the changelog (docs/reference/changelog.rst)?

Fixes #999
CRAFT-4064

@upils upils force-pushed the work/CRAFT-4064-Allow-slashes-in-partition-names branch from a9395e5 to 17bb699 Compare February 4, 2025 11:25
@upils upils requested review from mr-cal and cmatsuoka February 4, 2025 12:56
mr-cal
mr-cal approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well written for a complex algorithm, nice work

cmatsuoka
cmatsuoka requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a pass, I think we can fix a couple of typos (maybe result of some global find-and-replace operation), add some comments, simplify the implementation a bit and check if we could change any algorithms.

craft_parts/utils/partition_utils.py Show resolved Hide resolved
craft_parts/utils/partition_utils.py Outdated Show resolved Hide resolved
craft_parts/utils/partition_utils.py Show resolved Hide resolved
craft_parts/utils/partition_utils.py Outdated Show resolved Hide resolved
craft_parts/utils/partition_utils.py Outdated Show resolved Hide resolved
craft_parts/utils/partition_utils.py Outdated Show resolved Hide resolved
craft_parts/utils/partition_utils.py Outdated Show resolved Hide resolved
craft_parts/utils/partition_utils.py Outdated Show resolved Hide resolved
craft_parts/utils/partition_utils.py Outdated Show resolved Hide resolved
craft_parts/utils/partition_utils.py Outdated Show resolved Hide resolved
@upils upils requested review from cmatsuoka and mr-cal February 5, 2025 10:12
mr-cal
mr-cal approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even simpler, nice work.

cmatsuoka
cmatsuoka approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@mr-cal
Copy link
Contributor

mr-cal commented Feb 5, 2025

@upils - @bepri landed his PR in #1003, so you are welcome to update the changelog with your change and the release date. Once you land this PR, you can push a signed tag and the release will happen automatically in CI.

@upils upils force-pushed the work/CRAFT-4064-Allow-slashes-in-partition-names branch from 28f18fc to 3415488 Compare February 6, 2025 07:19
@upils upils force-pushed the work/CRAFT-4064-Allow-slashes-in-partition-names branch from 3415488 to 0d0db2a Compare February 6, 2025 07:31
@upils upils merged commit c2e4189 into main Feb 6, 2025
13 checks passed
@upils upils deleted the work/CRAFT-4064-Allow-slashes-in-partition-names branch February 6, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmatsuoka cmatsuoka cmatsuoka approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow slashes in partition names
3 participants
@upils @mr-cal @cmatsuoka