Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #80

Merged
merged 32 commits into from
Dec 20, 2024
Merged

Update README #80

merged 32 commits into from
Dec 20, 2024

Conversation

swetha1654
Copy link
Contributor

Overview

Updated the README file to be compliant with is-charms-template-repo

Checklist

@swetha1654 swetha1654 added documentation Improvements or additions to documentation trivial labels Dec 11, 2024
@swetha1654 swetha1654 requested a review from a team as a code owner December 11, 2024 14:06
@swetha1654 swetha1654 requested a review from erinecon December 11, 2024 14:07
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this README! It looks really great. I have two suggestions :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@swetha1654 swetha1654 requested a review from erinecon December 12, 2024 05:08
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README! I approve of this doc change 👍
(Not giving an official approval since there are code changes in this PR.)

Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small comments related to the style guide

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
swetha1654 and others added 3 commits December 13, 2024 11:52
Co-authored-by: Erin Conley <[email protected]>
Co-authored-by: Erin Conley <[email protected]>
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README! I approve of the doc changes 👍
(Not giving an official approve due to the code changes in this PR.)

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

Test coverage for 7b2131d

Name                 Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------
src/charm.py           186     11     34      8    91%   146-147, 167-168, 187, 227-229, 243->255, 328->331, 353, 366, 375->378, 460
src/file_reader.py      17      0      4      0   100%
----------------------------------------------------------------
TOTAL                  203     11     38      8    92%

Static code analysis report

Run started:2024-12-20 05:03:42.343896

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1269
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@swetha1654 swetha1654 merged commit dde44d1 into main Dec 20, 2024
17 checks passed
@swetha1654 swetha1654 deleted the ISD-2546-readme branch December 20, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Libraries: OK trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants