Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change ansible pull module type from dict to list #6010

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shaerpour
Copy link
Contributor

@shaerpour shaerpour commented Feb 6, 2025

Proposed Commit Message

feat: Change ansible pull module type from dict to list

Change ansible pull module to list so it can run 
multiple playbooks like setup_controller module.

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Fixes GH-4566

@github-actions github-actions bot added the documentation This Pull Request changes documentation label Feb 6, 2025
@shaerpour shaerpour force-pushed the ansible-pull-list branch 2 times, most recently from 1789b7e to 56ba447 Compare February 12, 2025 09:21
@holmanb
Copy link
Member

holmanb commented Feb 20, 2025

Hi @shaerpour, thanks for this proposal! It looks pretty good, but there's one big thing we need to address. If we shipped a new version of cloud-init with this feature it would break everybody that is currently using the old non-array version. Can you please modify this PR to support the old format as well?

@shaerpour
Copy link
Contributor Author

Dear @holmanb.
Absolutely! I will work on backward compatibility of this PR and update ASAP. Thank you for mentioning.

Copy link

github-actions bot commented Mar 7, 2025

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Mar 7, 2025
@shaerpour shaerpour force-pushed the ansible-pull-list branch from 56ba447 to f29a389 Compare March 8, 2025 07:39
@github-actions github-actions bot removed the stale-pr Pull request is stale; will be auto-closed soon label Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This Pull Request changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement]: Allow ansible pull to run multiple playbooks
2 participants