[ce-oem] Add wifi AP mode test (New) #1606
Open
+461
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickwu666666
added
the
ce-oem
rickwu666666
requested review from
baconYao,
weizhenwu,
LiaoU3 and
stanley31huang
rickwu666666
changed the title
rickwu666666
force-pushed
the
add-wifi-ap-mode-test
branch
from
6810613 to
a23c84e
Compare
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/wifi_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/wifi_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/wifi_test.py
Outdated
Show resolved
Hide resolved
stanley31huang
requested changes
Nov 29, 2024
rickwu666666
force-pushed
the
add-wifi-ap-mode-test
branch
from
cb0d340 to
a41429a
Compare
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/wifi_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/wifi_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/wifi_test.py
Outdated
Show resolved
Hide resolved
rickwu666666
force-pushed
the
add-wifi-ap-mode-test
branch
from
3176bba to
5d90c5e
Compare
Co-authored-by: stanley31huang <[email protected]>
Since this will make the function outside WiFiManager can call it without init the WiFiManager
… command to connect dut's ap
Co-authored-by: stanley31huang <[email protected]>
Co-authored-by: stanley31huang <[email protected]>
Make subprocess check the status instead of capture the exception
Since we add debug log about the running command. Therefore, we don't need --set-ap-only anymore. Since it originally design for debug purpose
…nd usage more clear
rickwu666666
force-pushed
the
add-wifi-ap-mode-test
branch
from
5d90c5e to
f29442a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1606 +/- ##
=======================================
Coverage 48.85% 48.85%
=======================================
Files 370 370
Lines 40234 40234
Branches 6794 6794
=======================================
Hits 19657 19657
Misses 19857 19857
Partials 720 720 ☔ View full report in Codecov by Sentry. |
This default set will be get the first available wireless interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wifi ap mode test are intend to test if DUT is able to create wifi AP and allow a HOST to connect with. And also the HOST will perform ping test to make sure the connection works fine.
Description
This test require a HOST machine to connect to DUT's AP. And support only if wireless interface managed by Network-Manager for both DUT and HOST, since networkd does not support handle wireless interface working in AP mode[1].
Also, even the Network-Manager is able to handle wireless interface working in AP mode but it support only on band a and bg[2].
[ref 1] https://netplan.readthedocs.io/en/stable/netplan-yaml/#properties-for-device-type-wifis
[ref 2] https://networkmanager.dev/docs/api/latest/settings-802-11-wireless.html
Resolved issues
Documentation
Tests
Passed result:
Failed result: