Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): promote command #2082

Merged
merged 9 commits into from
Jan 24, 2025
Merged

feat(store): promote command #2082

merged 9 commits into from
Jan 24, 2025

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Jan 16, 2025 •
edited
Loading

This adds a promote command allowing promotion from one channel to another, with limitations (e.g. cannot promote to a less stable channel).

Fixes #1633

@lengau lengau requested review from dariuszd21 and mr-cal January 16, 2025 23:52
@lengau lengau marked this pull request as ready for review January 16, 2025 23:52
dariuszd21
dariuszd21 requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few minor comments but nothing major

charmcraft/application/commands/store.py Outdated Show resolved Hide resolved
charmcraft/application/commands/store.py Outdated Show resolved Hide resolved
charmcraft/application/commands/store.py Show resolved Hide resolved
charmcraft/application/commands/store.py Show resolved Hide resolved
charmcraft/application/commands/store.py Show resolved Hide resolved
uv.lock Outdated Show resolved Hide resolved
dariuszd21
dariuszd21 reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

charmcraft/application/commands/store.py Show resolved Hide resolved
cmatsuoka
cmatsuoka approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks reasonable under my assumptions, but I missed the complete context because the PR has no description.

charmcraft/application/commands/store.py Outdated Show resolved Hide resolved
@lengau lengau requested a review from dariuszd21 January 17, 2025 23:39
dariuszd21
dariuszd21 requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my different stand on allowing "implicit" track, I think this is ready to be deliver if tests for the command will be in place

charmcraft/application/commands/store.py Show resolved Hide resolved
charmcraft/application/commands/store.py Show resolved Hide resolved
charmcraft/application/commands/store.py Show resolved Hide resolved
@lengau lengau requested a review from dariuszd21 January 22, 2025 17:48
mr-cal
mr-cal approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

charmcraft/application/commands/store.py Outdated Show resolved Hide resolved
charmcraft/application/commands/store.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
dariuszd21
dariuszd21 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thank you!

charmcraft/application/commands/store.py Outdated Show resolved Hide resolved
@lengau lengau merged commit 6d54238 into main Jan 24, 2025
27 of 28 checks passed
@lengau lengau deleted the CRAFT-2708/promote branch January 24, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@dariuszd21 dariuszd21 dariuszd21 approved these changes

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

charmcraft promote command
4 participants
@lengau @cmatsuoka @dariuszd21 @mr-cal