fix(models/project): make no parts error explicit #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
force-pushed
the
work/2055/CRAFT-3851
branch
3 times, most recently
from
67faf7d to
b222b6f
Compare
There were previously edge cases where a platform charm could be declared but the lack of a `parts` key wouldn't be caught. This now enforces at least one part.
lengau
force-pushed
the
work/2055/CRAFT-3851
branch
from
b222b6f to
f47eb10
Compare
|
macos failure is: actions/runner-images#11370 I'll re-run those tests when I can. |
mr-cal
approved these changes
Jan 14, 2025
bepri
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were previously edge cases where a platform charm could be declared but the lack of a
partskey wouldn't be caught. This now enforces at least one part.Fixes #2055
CRAFT-3851