Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support 18.04 #27

Closed
wants to merge 1 commit into from
Closed

Add support 18.04 #27

wants to merge 1 commit into from

Conversation

xtrusia
Copy link
Contributor

@xtrusia xtrusia commented Jun 18, 2024

Add support 18.04 as the customer is using bionic. Also focal should be supported in charmhub.

wolsen
wolsen requested changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@wolsen wolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually add functional tests to test on bionic. I have found that this fails in practice. Before we merge this, we should have functional tests for bionic.

@xtrusia
Copy link
Contributor Author

xtrusia commented Jun 19, 2024

This doesn't actually add functional tests to test on bionic. I have found that this fails in practice. Before we merge this, we should have functional tests for bionic.

I built the charm with 'charmcraft pack' and tried to deploy "./lldpd_ubuntu-18.04-amd64.charm" but it failed as juju 3.1 doesn't seem to support bionic.
with juju 2.9.49, I can deploy it.
If so, we don't support bionic for this charm anymore?

Thanks a lot.

@xtrusia xtrusia requested a review from wolsen July 2, 2024 03:12
@xtrusia
Copy link
Contributor Author

xtrusia commented Jul 2, 2024

This doesn't actually add functional tests to test on bionic. I have found that this fails in practice. Before we merge this, we should have functional tests for bionic.

I built the charm with 'charmcraft pack' and tried to deploy "./lldpd_ubuntu-18.04-amd64.charm" but it failed as juju 3.1 doesn't seem to support bionic. with juju 2.9.49, I can deploy it. If so, we don't support bionic for this charm anymore?

Thanks a lot.

I've checked code further and inserted and changed some dependencies. but not sure it is correct yet. please review my changes.
Thanks a lot.

@xtrusia
Add support 18.04
8896af5 
- Add 18.04 to charmcraft
- Change dependency libjuju to <3.0 to support bionic
- Change github ci to support juju 2.9
- fixed ruff issue

Signed-off-by: Seyeong Kim <[email protected]>
@xtrusia xtrusia closed this Jul 11, 2024
@xtrusia
Copy link
Contributor Author

xtrusia commented Jul 11, 2024

had a discussion and created stable/bionic to support bionic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolsen wolsen Awaiting requested review from wolsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xtrusia @wolsen