Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: push correct origin for button events #1512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: push correct origin for button events #1512

wants to merge 1 commit into from

Conversation

samhotep
Copy link
Member

@samhotep samhotep commented Jan 17, 2025 •
edited
Loading

Done

  • Updated values for origin and to in GAEvents to submit correct paths when the event comes from a button.

QA

eventAction: "from: /data/opensearch to: data/opensearch#get-in-touch"

where the from: is the url of the page, and the to: is the url of the modal

Issue / Card

Fixes WD-13714

Screenshots

image

@webteam-app
Copy link

Demo

Jenkins

demos.haus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samhotep @webteam-app