Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page refresh: /solutions/ai #1455

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Page refresh: /solutions/ai #1455

wants to merge 2 commits into from

Conversation

goulinkh
Copy link
Contributor

@goulinkh goulinkh commented Dec 9, 2024

Done

  • page refresh: AI solutions

QA

Issue / Card

Fixes WD-17320

@webteam-app
Copy link

@eliman11
Copy link
Collaborator

Thanks @goulinkh, looks great!

  • The hero should look like the existing page with a 50/50 split and an embedded video on the right. We've amended the design on Figma - apologies for the confusion!
  • Could you capitalize 'Ai infrastructure' to be 'AI infrastructure' under 'Use cases'
  • Add missing 4th article under 'AI resources' section (MicroK8s with Charmed Kubeflow on NVIDIA EGX platform
    Download the reference architecture for a detailed guide to infrastructure for machine learning use cases.)
  • Could you add aria labels to logo cloud section please? I've added them to the copydoc
  • Without changing styling, could we add h3 HTML tags to the subheadings under the images (i.e. Confidential AI, Data science, etc)
Screenshot 2024-12-10 at 14 37 19

@mattea-turic
Copy link
Collaborator

Thank you @goulinkh ! It looks great already :) Just a few small things from me:

  • As @eliman11 already mentioned, I overlooked the fact that a video should belong in the hero, so could you change this to a 50/50 split and embed the video there pls?

For this section:
Screenshot 2024-12-10 at 16 31 02

  • I noticed the Intel logo isn't quite aligned with the other logos, so I added an updated asset, if you could replace the existing one

For this section:
Screenshot 2024-12-10 at 16 35 00

  • Could you wrap the H2 in a shallow pls
  • And also add a hr above the "fast-track compliance..." subsection?

For this section:
Screenshot 2024-12-10 at 17 12 24

  • Could you use a link rather than a button, and add it in like so:
Screenshot 2024-12-10 at 17 11 03
  • And also there looks to be too much whitespace between the quotes, so could you make sure to wrap the first one in a shallow (I think it's a reg. one rn)

For this section:
Screenshot 2024-12-10 at 17 16 35

  • Could you add a hr above pls?

@goulinkh
Copy link
Contributor Author

Thanks for the review @mattea-turic and @eliman11 ! I've applied the requested changes, please let me know if they are matching what you expect and feel free to add further change requests if needed.

@eliman11
Copy link
Collaborator

Thanks @goulinkh for the changes! Looks good to me from UX for now - @mattea-turic probably mentioned already but we're waiting for external approval before going live so I'll keep the tag as UX needed for now in case anything changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants