-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix forms generator bugs #1443
Fix forms generator bugs #1443
Conversation
07290ec
to
13a910a
Compare
@@ -3,80 +3,24 @@ | |||
"/data/postgresql": { | |||
"templatePath": "/data/postgresql/index.html", | |||
"isModal": true, | |||
"modalId": "contact-modal", | |||
"modalId": "data-relational-dbs-modal", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep in mind that on ubuntu.com we use the modal id to fetch the modal in dynamic-forms.js and on c.com we use the .p-modal
class. We should be trying to align the scripts for a future merge (not saying this is wrong at all)
I'm unsure if there were any previous discussions with Design regarding the form design changes, this was the design shown when I imported the form templates. |
Hi, the "old" version is what was designed by visual. The "current version" looks like something that has not undergone visual. Can we simply implement this as agreed? From my records, this is the final template, with a "ready for dev" label on it. Complete with responsive mockups for smaller screens. |
13a910a
to
5a34f93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just one q, why is there now a 'how many machines?' question in the form?
Thanks for the +1 @petesfrench! I will remove that field before merging, it was added just for QA purposes :) |
Note: form template usage document should be updated once this is merged
Done
/data/postgresql
modalid=about-you
to be excluded fromComments_from_lead__c
modal.js
fileforms-data.json
to accept params:radio
,checkbox
,checkbox-visibility
QA
Comments_from_lead__c
only includes the comments from "Tell us about your use case" text areaIssue / Card
Fixes WD-17343 and #1399
Screenshots
[if relevant, include a screenshot]